python / python/bedevere

Accept "I have made the requested changes..." in PR review comments

Open
#499 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
141
Forks
62
Avg merge
5m
Merged PRs (30d)
2

Description

probably, new_comment() function should handle also the pull_request_review_comment (created) events. Or the bot message should be more verbose to specify the required type of comments.

See e.g. this comment, which was ignored by bot.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the new_comment() function and the event handling for pull_request_review_comment (created) events. Compare the linked CPython review comment with the bot behavior and determine whether review comments should be accepted or the bot guidance should be clarified. Done means the requested comment form is handled consistently and covered by the project’s existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.