python-trio / python-trio/trio

Test against *old* versions of requirements in CI

Open
#913 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.3k
Forks
431
Avg merge
2d 17h
Merged PRs (30d)
6

Description

I just noticed that our attrs requirement went from 18.1.0 → 18.2.0 at some point without our noticing (#912). Easy to fix, but it would be nice if our CI would catch this kind of thing.

Ideally we should have a CI job that installs the oldest version of all the packages that we claim to be compatible with, and runs our tests against that.

Implementing this might be kind of annoying. We already have to keep duplicate copies of our install-requires in setup.py, test-requirements.in, and ci/rtd-requirements.in, and then I guess this would be a third set, with slightly different bounds? Ugh.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the dependency declarations in setup.py, test-requirements.in, and ci/rtd-requirements.in, then review how the current CI installs requirements and runs tests. Add a CI job that installs the oldest claimed compatible package versions and runs the test suite successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.