python-trio / python-trio/trio
Add tests to test_exports that check allcaps constants re-exports
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.3k
- Forks
- 431
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 6
Description
#791 added a test in test_subprocess.py to check that trio.subprocess is re-exporting all the constants from subprocess. We should move this to test_exports.py and generalize it to check trio.ssl and trio.socket, as well. (Or maybe we already have some tests in there for that? If so we should combine them instead of having multiple ad hoc duplicates of the same thing.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing re-export test in test_subprocess.py and the related tests, if any, in test_exports.py. Move or combine the coverage there so it checks all-uppercase constants for trio.subprocess, trio.ssl, and trio.socket against their standard-library counterparts. Done means test_exports.py provides consolidated coverage without duplicate ad hoc tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100