python-trio / python-trio/trio
Missing Cygwin support
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.3k
- Forks
- 431
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 6
Description
The explicit usage of sys.platform as
sys.platform == "linux"
sys.platform == "android"
sys.platform == "win32"
to test the enviroment preclude running trio on cygwin as unsupported platform.
As linux, android, cygwin all have
os.name='posix'
can you please be a bit more inclusive ?
Trio is the only package, that I have found, to have such restricted views and unfortunately is used as needed dependency by other packages
python-tox | ImportError: cannot import name 'current_kqueue' from 'trio._core._run'
python-sniffio | cannot import name 'current_kqueue' from 'trio._core._run'
python-urllib3 | ImportError: cannot import name 'current_kqueue' from 'trio._core._run'
python-decorator | cannot import name 'current_kqueue' from 'trio._core._run'
Thanks in advance
Marco Atzeri (Cygwin Python package maintainer)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching for the explicit sys.platform checks described in the issue and tracing trio._core._run, especially current_kqueue imports, while reproducing the reported Cygwin import failures. Done means Cygwin no longer hits the unsupported-platform path and the listed dependent imports work without ImportError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100