python-trio / python-trio/trio

Replace check.sh and/or ci.sh with tox/nox

Open
#3,170 5 comments 1 reaction 1 assignee View on GitHub

@webknjaz is already working on this.

Since Dec 26, 2024.

project meta
Dominant language
Python
Stars
7.3k
Forks
431
Avg merge
2d 17h
Merged PRs (30d)
6

Description

Tox sounds wonderful. I've been meaning to suggest it. I've actually been working on some reusable workflows for tox-based projects + experimented with some cool GHA integrations.
When you get to it, I may offer some help / experimentation in simplifying things here.

Originally posted by @webknjaz in https://github.com/python-trio/trio/pull/3157#discussion_r1895163518

thread contains more discussion on tox vs nox. Whoever wants to Do It can probably just decide on either.

Initial PR does not need to be a huge one that replaces all of check.sh & ci.sh and overhauls CI stuff, an incremental approach should work perfectly fine here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.