python-trio / python-trio/trio
add mypy run on py3.13
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.3k
- Forks
- 431
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 6
Description
As noticed in https://github.com/python-trio/trio/pull/3162#issuecomment-2557061317 & https://github.com/python-trio/trio/pull/3162#issuecomment-2557465927 we have code guarded by if sys.version_info > (3, ...) that currently isn't type checked at all.
So we should probably test both lowest & highest supported python version with mypy. Should be fairly straightforward: duplicate the code in check.sh and fix the one error in _path.py.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in check.sh, where the existing mypy invocation is defined, and inspect _path.py for the reported type-checking error. Run the current checks for both the lowest and highest supported Python versions, then confirm both mypy runs pass and the guarded code is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ci-cd, testing-qa
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100