python-trio / python-trio/trio
Add `coverage-conditional-plugin`
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.3k
- Forks
- 431
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 6
Description
Consider integrating the `covdefaults` plugin, as it injects most of these automatically. The only thing you'd need to override additionally is the `fail_under` setting, which it sets to 100%, but it's not compatible with runtime-dependent tests that cannot reach 100% under one specific runtime. So it's good to set it to something sufficiently low while requiring 100% in Codecov.
Originally posted by @webknjaz in https://github.com/python-trio/trio/pull/3159#discussion_r1894210576
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the coverage configuration and the discussion in pull request #3159, then check how the covdefaults plugin handles the fail_under setting. Done means coverage-conditional-plugin is integrated, fail_under is set below 100% for runtime-dependent tests, and Codecov still requires 100% coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100