python-trio / python-trio/trio
Make SSLStream more robust against cancellation
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.3k
- Forks
- 431
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 6
Description
This requires adding a bit of complexity in how Stream.send_all methods respond to cancellation in general. (It might also help with #147...) See discussion here: https://github.com/python-trio/trio/pull/107#issuecomment-306192344
The motivating use case is that it would make it pretty straightforward to add trio support to the next generation of urllib3. (If I can convince @Lukasa that this isn't a terrible idea to start with. Stay tuned...)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the Stream.send_all cancellation discussion linked from issue #198, along with the referenced PR #107 comment and issue #147. Trace how SSLStream uses send_all and clarify the intended cancellation behavior before changing anything; the issue does not specify concrete acceptance criteria or a test file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100