python-trio / python-trio/trio
review PR merge policy
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.3k
- Forks
- 431
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 6
Description
From contributing docs:
We do have one rule, which is the same one most F/OSS projects use: don't merge your own PRs. We find that having another person look at each PR leads to better quality.
"Having another person look at each PR" is not controversial. However it's not obvious why this necessitates a "don't merge your own PR" rule. Requiring approval from a Trio organization member may be sufficient for our goal, and GitHub allows such policy to be enforced on a project.
While there is also the external / first time PR contributor case, this rule is only relevant to PR's authored by existing organization members (which by Trio's contribution policy is anyone with a PR merged in the past).
recent/consistent contributors for input: @njsmith @pquentin @smurfix @oremanj
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the quoted merge rule in the contributing docs and the GitHub policy options mentioned in the issue. Read the discussion and seek input from the named contributors before deciding whether the rule should remain or change. Done means an agreed policy is reflected consistently in the contribution guidance and, if applicable, GitHub settings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- developer-experience, documentation
- Issue type
- Documentation
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100