python-trio / python-trio/flake8-async
full `# noqa` support
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
Making a separate issue from #181 to track all current issues/TOODs with # noqa
0 Respectnoqa-trioas a way to have full flake8-noqa support- 1 Don't autofix
noqa'd errors- This might not be a huge issue atm, but is a must going forward as more visitors get autofix support.
- 2 Raise error if invalid (or not enabled) TRIO error code is noqa'd.
- Not a must, and sort of covered by
flake8-noqa. But if it's a simple logic addition there's not much reason not to.
- Not a must, and sort of covered by
- 3 raise
noqad errors when running as a plugin #188- otherwise we're fully incompatible with flake8-noqa
- 4 support
--disable-noqa - 5 document current level of [in]compatibility with flake8-noqa
- 6 respect
# noqain ast visitors. #188 - 7 check that
# noqacomments are resilient to line numbers changing due to autofix.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the remaining checklist and the flake8-noqa compatibility context; the issue identifies autofix handling, invalid-code validation, --disable-noqa, documentation, and line-number resilience as entry points. Done requires addressing the selected outstanding items and confirming the corresponding noqa behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100