python-poetry / python-poetry/tomlkit

updating a table captures too many keys

Open
#556 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
850
Forks
162
Avg merge
13m
Merged PRs (30d)
2

Description

#!/usr/bin/env python3

import tomlkit

doc = tomlkit.loads("a.b = 1\na.c = 2\na.d = 3\n")
doc["a"]["b"] = {"x": 9}

output = tomlkit.dumps(doc)

print(output)

result

[a.b]
x = 9
a.c = 2
a.d = 3

in which a.c and a.d have become children of the [a.b] table

similar to #542, #543, but not fixed by PRs currently open for those so should be distinct.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the Python reproduction in the issue and inspect how assigning a mapping to doc["a"]["b"] affects table structure and serialization. Trace the relevant table-update and dump paths; done means tomlkit emits [a.b] with x = 9 while a.c and a.d remain sibling tables, with regression coverage for this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.