python-poetry / python-poetry/tomlkit
[self-tests] several failures against toml-test 1.1.0
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 850
- Forks
- 162
- Avg merge
- 13m
- Merged PRs (30d)
- 2
Description
I've updated toml-test for my distro (1.1.0).
after that tomlkit's tests suite fails with:
=================================== FAILURES ===================================
_____________ test_invalid_decode[table/append-with-dotted-keys-2] _____________
invalid_decode_case = {'toml': '# This is the same issue as in injection-1.toml, except that nests one level\n# deeper. See that file for a ...= 9\n\n[a]\n b.c.d.k.t = "Using dotted keys to add to [a.b.c.d] after explicitly defining it above is not allowed"\n'}
def test_invalid_decode(invalid_decode_case):
> with pytest.raises(TOMLKitError):
E Failed: DID NOT RAISE <class 'tomlkit.exceptions.TOMLKitError'>
tests/test_toml_tests.py:55: Failed
_____________ test_invalid_decode[table/append-with-dotted-keys-1] _____________
invalid_decode_case = {'toml': '# First a.b.c defines a table: a.b.c = {z=9}\n#\n# Then we define a.b.c.t = "str" to add a str to the above ...\n z = 9\n\n[a]\n b.c.t = "Using dotted keys to add to [a.b.c] after explicitly defining it above is not allowed"\n'}
def test_invalid_decode(invalid_decode_case):
> with pytest.raises(TOMLKitError):
E Failed: DID NOT RAISE <class 'tomlkit.exceptions.TOMLKitError'>
tests/test_toml_tests.py:55: Failed
___________________ test_invalid_decode[control/comment-cr] ____________________
invalid_decode_case = {'toml': 'comment-cr = "Carriage return in comment" # \na=1\n'}
def test_invalid_decode(invalid_decode_case):
> with pytest.raises(TOMLKitError):
E Failed: DID NOT RAISE <class 'tomlkit.exceptions.TOMLKitError'>
tests/test_toml_tests.py:55: Failed
_____________________ test_invalid_decode[control/bare-cr] _____________________
invalid_decode_case = {'toml': '# The following line contains a single carriage return control character\n\n'}
def test_invalid_decode(invalid_decode_case):
> with pytest.raises(TOMLKitError):
E Failed: DID NOT RAISE <class 'tomlkit.exceptions.TOMLKitError'>
tests/test_toml_tests.py:55: Failed
=========================== short test summary info ============================
FAILED tests/test_toml_tests.py::test_invalid_decode[table/append-with-dotted-keys-2]
FAILED tests/test_toml_tests.py::test_invalid_decode[table/append-with-dotted-keys-1]
FAILED tests/test_toml_tests.py::test_invalid_decode[control/comment-cr] - Fa...
FAILED tests/test_toml_tests.py::test_invalid_decode[control/bare-cr] - Faile...
======================== 4 failed, 800 passed in 9.35s =========================
tomlkit 0.9.0.
I understand that this project submodules toml-test (1.0.0 atm).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/test_toml_tests.py and the toml-test submodule version mentioned in the report. Run the suite against toml-test 1.1.0 and inspect the four invalid_decode failures involving dotted keys and carriage returns. Done means the compatibility issue is resolved and the full self-test suite passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100