python-poetry / python-poetry/poetry
symlink can raise NotImplementedError
Open
Nobody has claimed this yet.
kind/bug
status/triage
- Dominant language
- Python
- Stars
- 34.3k
- Forks
- 2.5k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 30
Description
- I am on the latest Poetry version.
- I have searched the issues of this repo and believe that this is not a duplicate.
- If an exception occurs when executing a command, I executed it again in debug mode (
-vvvoption).
- OS version and name: windows
- Poetry version: HEAD
- Link of a Gist with the contents of your pyproject.toml file:
Issue
PyPy does not yet implement os.symlink on windows. If poetry wishes to support PyPy on windows, this line needs to also trap NotImplementedError https://github.com/python-poetry/poetry/blob/656c71d46f5cd35ac7996b00c631e5056c883b55/install-poetry.py#L561
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open install-poetry.py around line 561 and inspect the symlink handling for the Windows installation path. Confirm how PyPy behaves when os.symlink is unavailable, then ensure that NotImplementedError is handled there as described. Done means the installation path no longer raises this exception for PyPy on Windows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100