python-poetry / python-poetry/poetry

Incorrect wheel tag for platform-dependent packages on PyPy

Open
#1,820 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug
Dominant language
Python
Stars
34.3k
Forks
2.5k
Avg merge
2d 19h
Merged PRs (30d)
30

Description

Issue

When running on PyPy and having the build key in pyproject.toml, Poetry chooses a wheel tags that is not supported by the platform, so it cannot be installed afterwards.

When running docker build . with files from the linked Gist:

Step 6/7 : RUN poetry build
 ---> Running in a893c9f76461
Creating virtualenv wheeltagtest-9TtSrW0h-py3.6 in /root/.cache/pypoetry/virtualenvs
Building wheeltagtest (0.1.0)
 - Building sdist
 - Built wheeltagtest-0.1.0.tar.gz

 - Building wheel
 - Built wheeltagtest-0.1.0-pp369-pypy36_pp73-linux_x86_64.whl
Removing intermediate container a893c9f76461
 ---> c99768df9fda
Step 7/7 : RUN poetry run pip install dist/*.whl
 ---> Running in 33d70ae40527
ERROR: wheeltagtest-0.1.0-pp369-pypy36_pp73-linux_x86_64.whl is not a supported wheel on this platform.
The command '/bin/sh -c poetry run pip install dist/*.whl' returned a non-zero code: 1

A proper wheel tag would contain pp373 instead of pp369: this runs on PyPy 7.3.0 (which is otherwise compatible with Python 3.6.9).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the linked pyproject.toml and Docker setup by running poetry build under PyPy, then installing the generated wheel with poetry run pip install. Trace how the wheel tag is selected. Done means the PyPy 7.3.0 environment receives a compatible pp373 tag and can install the built wheel.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.