python-poetry / python-poetry/poetry-plugin-export

Pre-commit hook for poetry-export should use same sort strategy as pre-commit/requirements-txt-fixer

Open
#156 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
335
Forks
57
Avg merge
1h 23m
Merged PRs (30d)
3

Description

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

Pre-commit is excellent for standardizing checks across an organization's repositories. There's a conflict when trying to use poetry-export with pre-commit/requiremenets-txt-fixer as they sort differently.

E.g. the poetry-export hook will put pytest-cov above pytest, while pre-commit/requirements-txt-fixer will do the opposite.

While some may argue to "use one or the other", that makes it difficult to share a standardized .pre-commit-config.yaml across all repos of an org for consistency. Some repos may be currently using poetry or not or are slowing transitioning to use it.

This request is related to python-poetry/poetry#6944

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the poetry-export pre-commit hook with pre_commit_hooks/requirements_txt_fixer.py, which the issue identifies as the desired sorting reference. Reproduce the pytest/pytest-cov ordering difference, then locate the hook's existing tests or entry point. Done means poetry-export produces the same ordering strategy as requirements-txt-fixer and the example is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.