python-pillow / python-pillow/Pillow
Some unpackers are misnamed
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13.8k
- Forks
- 2.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 89
Description
RGB15 actually reads data as XBGR (XBBBBBGGGGGRRRRR).
RGBA15 actually reads data as ABGR (ABBBBBGGGGGRRRRR).
RGBA4B actually reads data as ABGR (AAAABBBBGGGGRRRR).
etc.
Basically, all of the unpackers that read less than 8 bits per band appear to be backwards.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/libImaging/Unpack.c at lines 661-674, 676-689, and 766-779, then inspect the other unpackers that read less than 8 bits per band. Verify the channel ordering against each unpacker name and update the misnamed cases; done means the names match the formats actually read.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, python
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100