python-hyper / python-hyper/uritemplate

Variable names are not validated

Open
#51 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
246
Forks
39
Avg merge
13h 38m
Merged PRs (30d)
1

Description

The RFC limits the characters allowed in variables names, but there is no validation enforcing this.

From § 2.3:

 variable-list =  varspec *( "," varspec )
 varspec       =  varname [ modifier-level4 ]
 varname       =  varchar *( ["."] varchar )
 varchar       =  ALPHA / DIGIT / "_" / pct-encoded

(I'm not opposed to expanding the set of allowed characters.)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name any files, tests, or entry points. Start by locating the variable-name parsing and validation code, then compare its accepted characters with the RFC 6570 grammar quoted here. Done means invalid variable names are rejected and coverage verifies the allowed characters.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.