python-hyper / python-hyper/rfc3986
Incorrect result returned by is_valid_uri()
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 189
- Forks
- 38
- Avg merge
- 13h 36m
- Merged PRs (30d)
- 1
Description
According to RFC 3986, there are some ABNF rules:
URI = scheme ":" hier-part [ "?" query ] [ "#" fragment ]
scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / ".")
And I tried:
>>> from rfc3986 import is_valid_uri
>>> is_valid_uri("1")
True
>>> is_valid_uri("//")
True
>>> is_valid_uri("http#:/")
True
I think these results are not correct.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the is_valid_uri() entry point and compare its handling of the three examples with the RFC 3986 grammar linked in the issue. Done means the examples are classified according to the stated URI and scheme rules, with regression coverage for the corrected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100