python-hyper / python-hyper/h2
The connection should emit a WindowUpdated event on INITIAL_WINDOW_SIZE change
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 187
- PR merge metrics
- No merged PRs in 30d
Description
I think the connection should emit a WindowUpdated event on receipt of a settings frame that changes the INITIAL_WINDOW_SIZE. This is because this frame is valid after the receipt of headers and hence it implicitly updates the window (see _flow_control_change_from_settings). Without emitting this frame implementations have to specifically look for this settings change and respond appropriately themselves.
(I'll implement this, just wanted to get views on whether this is the correct thing to do).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in h2/connection.py at _flow_control_change_from_settings, which the issue identifies as the relevant flow-control path. Trace how settings-frame handling currently exposes connection events and check the surrounding behavior before making the change. Done means a changed INITIAL_WINDOW_SIZE results in a WindowUpdated event, with the existing behavior preserved for other settings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend-api-design, networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100