python-hyper / python-hyper/brotlicffi
Testing of sdist fails
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 154
- Forks
- 34
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 3
Description
When I test sdist from PyPI it always fails:
ImportError while loading conftest '$(BUILDDIR)/test/conftest.py'.
test/conftest.py:11: in <module>
os.path.join(TEST_DATA_DIR, p) for p in os.listdir(TEST_DATA_DIR)
E FileNotFoundError: [Errno 2] No such file or directory: '$(BUILDDIR)/libbrotli/tests/testdata'
Apparently, the required directory is not in the sdist. Please add it there. Please also consider to add tox.ini to sdist.
Thank you.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/conftest.py and inspect how the source distribution is assembled. Check that the libbrotli/tests/testdata directory and tox.ini are present in the PyPI sdist, then run the sdist test to confirm conftest.py loads without FileNotFoundError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100