Subclass disambiguation for nested structures.

• cattrs version: 23.2.3
• Python version: 3.10.12
• Operating System: Ubuntu-22.04

I'm using attrs 23.2.0, if that matters.

Description

Hi! I am having trouble adding the special _type key to the unstructured data to inform the structurer how to deal with subtypes. It seems to work for the top level structure, but not a second level structure that also has subtypes.

Any help would be appreciated :-)

What I Did

This is some example code:

from enum import Enum
from attrs import define, field
import cattr
from cattrs.strategies import configure_tagged_union, include_subclasses

from typing import ClassVar, List


class Material(Enum):
    WOOD = "wood"
    PLASTIC = "plastic"


@define
class Toy:
    material: ClassVar[Material]

    name: str


@define
class Lego(Toy):
    material = Material.PLASTIC


@define
class Train(Toy):
    material = Material.WOOD


@define
class ToyBox:
    size: ClassVar[int]

    material: Material
    contents: List[Toy] = field(factory=list)

    def add_toy(self, toy):
        if len(self.contents) >= self.size:
            raise ValueError("ToyBox is full")
        self.contents.append(toy)


@define
class SmallToyBox(ToyBox):
    size = 5


@define
class LargeToyBox(ToyBox):
    size = 10


c = cattr.Converter()
include_subclasses(ToyBox, c, union_strategy=configure_tagged_union)
include_subclasses(Toy, c, union_strategy=configure_tagged_union)


box = SmallToyBox(material=Material.WOOD)
box.add_toy(Lego("space"))
box.add_toy(Lego("house"))
box.add_toy(Train("stream"))
box.add_toy(Train("electric"))

unstructured = c.unstructure(box)

import pprint
pprint.pprint(unstructured)

And I get the following:

{'_type': 'SmallToyBox',
 'contents': [{'name': 'space'},
              {'name': 'house'},
              {'name': 'stream'},
              {'name': 'electric'}],
 'material': 'wood'}

which, as you can see, is not including the _type argument in the nested data structure Toy that needs to deal with subtypes.

A possibly related issue is that I want to be able to string together multiple hooks together. Specifically I want to also include this:
hook = make_dict_unstructure_fn(Toy, c, _cattrs_omit_if_default=True) in addition to supporting subclasses.

How can I do that?

Thanks!

Start with c.unstructure after configuring include_subclasses for ToyBox and Toy with configure_tagged_union, and reproduce the nested Toy list case. Trace how the tagged-union hook is composed with make_dict_unstructure_fn(Toy, c, _cattrs_omit_if_default=True); done means nested subtype data includes _type while the existing top-level tag and requested hook behavior remain intact.