python-attrs / python-attrs/cattrs
cattrs structure string to List, instead of failing conversion
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 159
- Avg merge
- 12h 21m
- Merged PRs (30d)
- 6
Description
@attr.s
class Model:
field = attr.ib(type=List[str])
src_dict = {"field": "hello"}
cattrs.structure(src_dict, Model)
=> ["h", "e", "l", "l", "o"]
I'd expect it to fail converting.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the provided cattrs.structure example with a List[str] field and a string value. Trace the structure conversion entry point to determine why the string is treated as an iterable, then add coverage showing the conversion should fail for this input. Done means the example raises a conversion error rather than producing a list of characters.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100