pytest-dev / pytest-dev/pytest
`pytest.approx` fails with `TypeError` when testing approximate value of a `decimal.Decimal`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 14.5k
- Forks
- 3.4k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 35
Description
description
When testing the approximate value of a decimal.Decimal the following TypeError occurrs
TypeError: unsupported operand type(s) for -: 'float' and 'decimal.Decimal'
I would expect pytest.approx to test for approximate equality with a floating point value without having to either convert the decimal to a float or testing explicitly against another decimal.
pip list
Package Version
------------ -------
atomicwrites 1.4.0
attrs 20.3.0
colorama 0.4.4
iniconfig 1.1.1
packaging 20.9
pip 21.0.1
pluggy 0.13.1
py 1.10.0
pyparsing 2.4.7
pytest 6.2.2
setuptools 54.2.0
toml 0.10.2
pytest and os versions
pytest: 6.2.2
os: windows 10
minimal example
import decimal
import pytest
import math
3.14159 == pytest.approx(math.pi) # works
decimal.Decimal('3.14159') == pytest.approx(math.pi) # raises TypeError
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the pytest.approx entry point and reproduce the minimal Decimal/float example from the issue. Trace the approximate-comparison path and add regression coverage for that example; done means Decimal compared with a floating-point value no longer raises TypeError and still checks approximate equality.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100