pytest-dev / pytest-dev/pytest

pytest_raises call pytest_assertion_pass_hook

Open
#7,268 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: proposal
Dominant language
Python
Stars
14.5k
Forks
3.4k
Avg merge
2d 9h
Merged PRs (30d)
35

Description

Hi guys,

We find the pytest_assertion_pass_hook really useful for automatically providing logs on passing assertions.

However, another typical test we have in the tests are made by using pytest.raises. Unfortunately, we don't get logs automatically from that check.

I believe that it would be nice to have some sort of hook that we could use for that, that's why the suggestion for it to call the assertion_pass hook too. Or maybe another special hook for itself.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how pytest.raises handles expected exceptions and how pytest_assertion_pass_hook is invoked. Determine whether the requested behavior should reuse the existing hook or require a separate hook, then define observable logging behavior and tests for passing pytest.raises checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.