pytest-dev / pytest-dev/pytest
test_faulthandler.py::test_timeout[True] occasionally crashes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 14.5k
- Forks
- 3.4k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 35
Description
This tests the faulthandler_timeout functionality which dumps stacktraces of all threads of tests that run for more than a specified amount of times.
The test sometimes crashes with Windows fatal exception: access violation while dumping the threads. This is probably a cpython bug.
Noticed on both windows-py35 and windows-py37 jobs at least. (Update: also on pypy3-ubuntu).
For now I think we should just skip it on Windows, unless anyone has better ideas or ability to investigate. I'll send a PR doing that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test_faulthandler.py::test_timeout[True] and run the parametrized test on the affected environments. Read the faulthandler_timeout test setup and determine how the Windows crash can be avoided; done means the test no longer crashes on Windows while preserving coverage elsewhere, including the noted PyPy case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100