pytest-dev / pytest-dev/pytest
revisit relation between marks and keywords
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 14.5k
- Forks
- 3.4k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 35
Description
followup to #4564
classically marks where turned into keywords, by simply dumping the __dict__ of a function into a nodes keyword, implying the now removed MarkInfo objects landing in the keyword mapping
to ensure keywords keep working as they used to, i decided to add all mark names that where not already known keywords to the keywords of a node
but thats a pretty horrible hack and should be sorted out in a more principled manner
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #4564 and tracing the current relationship between marks, keywords, node keyword mappings, and the removed MarkInfo objects. Done means replacing the described keyword-population hack with a principled design while preserving the historical behavior of marks and keywords.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100