pytest-dev / pytest-dev/pytest

Don't create tmpdir simlink if --basetemp is used

Open
#3,715 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

plugin: tmpdir type: bug
Dominant language
Python
Stars
14.5k
Forks
3.4k
Avg merge
2d 9h
Merged PRs (30d)
35

Description

Using the option --basetemp has the consequence to create a link to each temporary directory, thus double the quantity of folders and let the temp directory less readable.

These link are generated by the method py.path.local.LocalPath.make_numbered_dir (see https://github.com/pytest-dev/py/issues/194)

Configuration

  • Ubuntu 14.04
  • pytest version 3.6.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how pytest handles --basetemp and how py.path.local.LocalPath.make_numbered_dir creates temporary-directory links. Reproduce the behavior on a supported environment, then verify that using --basetemp no longer creates an extra link while temporary directories still work as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.