pytest-dev / pytest-dev/pytest

ensure we no longer generate badtest ids

Open
#3,160 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

topic: collection type: bug
Dominant language
Python
Stars
14.5k
Forks
3.4k
Avg merge
2d 9h
Merged PRs (30d)
35

Description

followup to #2969

we do generate test ids with various nonprintable charaters, this has led to the issue fixed in #2969

however this also means the env vars in some cases has a completely wrong test id that does not match the real test id

we should ensure consistency there

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #2969, then trace pytest's test-ID generation and the handling of the related environment variables. Done means test IDs containing nonprintable characters no longer cause the environment-variable ID to differ from the real test ID, with regression coverage for the inconsistency.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.