pytest-dev / pytest-dev/pytest

pluginmanager validation kicks in too early when setuptools plugins use pytest_plugins

Open
#2,720 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

topic: config type: bug
Dominant language
Python
Stars
14.5k
Forks
3.4k
Avg merge
2d 9h
Merged PRs (30d)
35

Description

after updating to pytest 3.2 i had to move a hook implementation into a plugin object

will follow up with a reference to that code once i pushed it

the code in question is only triggered in worker processes of a own test parallelizing tool,
so it could be very well a underlying bug in pytest we just don't trigger usually/with xdist

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the pluginmanager validation path and reproduce the behavior with a setuptools plugin that uses pytest_plugins and moves a hook implementation into a plugin object. Focus on the worker-process case described in the issue and compare when validation occurs. Done means confirming and correcting the underlying early-validation behavior, with a regression test covering it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.