pytest-dev / pytest-dev/pytest
Let `OutcomeException` inherit from `Exception` instead of `BaseException`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 14.5k
- Forks
- 3.4k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 35
Description
What's the problem this feature will solve?
This allows for the usual handling and follows the Python documentation.
Describe the solution you'd like
Replace inheritance of OutcomeException from BaseException with Exception
Alternative Solutions
I can rewrite the code to expect a BaseException, but it does not follow Pythons recommend practice of inheriting user defined exceptions from Exception
Additional context
I'm curious to learn what the motivation is for inheriting from BaseException instead of Exception.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the pytest repository for the OutcomeException definition and review its usages to understand the current exception-handling expectations. Change its base class to Exception, then run the relevant pytest test suite and confirm exception handling remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100