pytest-dev / pytest-dev/pytest
`pytest.approx()` incorrectly flags nested sequences as unequal
Open
Nobody has claimed this yet.
topic: approx
- Dominant language
- Python
- Stars
- 14.5k
- Forks
- 3.4k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 35
Description
Consider this:
>>> a = [(1.20000000000001,)]
>>> b = [(1.2,)]
>>> a == pytest.approx(b)
False
On the other hand:
>>> a[0] == pytest.approx(b[0])
True
So I am assuming it is thrown off by the nested sequences.
I am using pytest 8.0.0.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the examples with pytest 8.0.0, then trace how pytest.approx compares nested sequences. Add a regression test covering the nested tuple case and verify that the outer comparison matches the inner comparison result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100