pytest-dev / pytest-dev/pytest

Make xpass a failure again

Open
#11,467 13 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

topic: reporting type: backward compatibility
Dominant language
Python
Stars
14.5k
Forks
3.4k
Avg merge
2d 9h
Merged PRs (30d)
35

Description

What's the problem this feature will solve?

Some years ago we accepted a change which made xpass not a failure

I recently hit multiple cases where it was missed that a test was fixed

That's not an acceptable default

Describe the solution you'd like
Alternative Solutions
Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how pytest currently classifies and reports xpass results, then review the issue's comment discussion for the intended behavior. Done means an unexpected pass is treated as a failure again, with tests covering the changed result and reporting behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.