pytest-dev / pytest-dev/pytest

Drop symlink creation in tmp_path

Open
#10,916 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

plugin: tmpdir type: proposal
Dominant language
Python
Stars
14.5k
Forks
3.4k
Avg merge
2d 9h
Merged PRs (30d)
35

Description

As discussed in https://github.com/pytest-dev/pytest/discussions/10910, seems like the symlinks created by tmp_path were useful a long time ago, during the dawn of pytest when testing pypy, and could be dropped. I personally never seen any use for it.

Should we drop them to simplify the code a bit? Any idea if we can somehow gauge if this is used?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the tmp_path implementation and its tests, then read the linked discussion about the historical symlinks. Determine whether the symlinks are still used and document the evidence; done means the project has a decided scope and corresponding tests or documentation for that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.