pytest-dev / pytest-dev/pytest-xdist

Crashed worker exits 0 (incorrectly) on Ubuntu, exits 2 on macOS, with `--max-worker-restart 0`

Open
#814 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.9k
Forks
287
Avg merge
9h 30m
Merged PRs (30d)
2

Description

This is bizarre, but locally on macOS 12.5.1 M1 a crashed worker exits nonzero, which is correct. But on Ubuntu 22.04 (GitHub-hosted action runner), a crashed worker exits zero and so the check incorrectly succeeds. This is bad, since it gives a false impression of tests passing.

pytest invocation

python -m pytest \
  -W error \
  -rA \
  -n auto \
  --max-worker-restart 0 \
  --durations 0 \
  --durations-min 5 \
  src/test/integration

versions

  • python 3.10.6
  • pytest 7.1.3
  • pytest-xdist 2.5.0

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the provided python -m pytest invocation, especially --max-worker-restart 0, on Ubuntu 22.04 and macOS 12.5.1. Trace pytest-xdist's worker-crash and process-exit handling; done means the same crashed-worker scenario reports a nonzero exit status on both platforms.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
distributed-systems, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.