pytest-dev / pytest-dev/pytest-xdist
Rsync very noisy in quiet mode
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.9k
- Forks
- 287
- Avg merge
- 9h 30m
- Merged PRs (30d)
- 2
Description
When bringing up test nodes, xdist rsyncs specified trees. The class responsible for that is xdist.workermanage.HostRSync.
In the _report_send_file method, it checks its verbosity level. If it is not 0, it prints out the node spec, local path, and remote path of the file being synchronized.
py.test can be run in quiet mode (-q), in which case its verbosity level will be -1 or lower. Which is not 0, so rsyncing messages flood the terminal.
The fix should be trivial — replace if self._verbose: with if self._verbose > 0: in xdist.workermanage.HostRSync._report_send_file. (Possibly push the threshold up a bit, so flood only happens at -vv or even higher.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open xdist.workermanage.HostRSync._report_send_file and inspect how the verbosity threshold controls rsync messages. Verify that quiet mode no longer floods the terminal while positive verbosity still reports synchronized files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100