pytest-dev / pytest-dev/pytest-xdist

Warnings generated by pytest-xdist

Open
#133 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
1.9k
Forks
287
Avg merge
9h 30m
Merged PRs (30d)
2

Description

While working on pytest-dev/pytest#2072 I noticed that pytest-xdist raises these warnings when running pytest's test suite:

  • addoption receiving a string instead of a type:

    File "c:\pytest\.tox\py35-xdist\lib\site-packages\xdist\plugin.py", line 36, in pytest_addoption
      help=("set mode for distributing tests to exec environments.\n\n"
    File "C:\pytest\_pytest\config.py", line 752, in _addoption
      option = Argument(*optnames, **attrs)
    File "C:\pytest\_pytest\config.py", line 639, in __init__
      stacklevel=3)
    DeprecationWarning: type argument to addoption() is a string 'choice'. For parsearg this is optional and when supplied should be a type. (options: ('--dist',))
    
  • inspect.getargspec on Python >= 3.5:

    INTERNALERROR>   File "c:\pytest\.tox\py35-xdist\lib\site-packages\execnet\gateway.py", line 186, in _source_of_function
    INTERNALERROR>     args, varargs, keywords, defaults = inspect.getargspec(function)
    INTERNALERROR>   File "c:\python35\Lib\inspect.py", line 1040, in getargspec
    INTERNALERROR>     stacklevel=2)
    INTERNALERROR> DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() instead
    

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the pytest_addoption path in xdist/plugin.py and the _source_of_function path in execnet/gateway.py shown in the warning traces. Run pytest-xdist's test suite under Python 3.5 or newer and verify that the reported deprecation warnings no longer occur.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
distributed-systems, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.