pytest-dev / pytest-dev/pytest-timeout

PR #200 introduced breaking change - `timeout` value in config is incompatible with older versions

Open
#203 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
258
Forks
69
PR merge metrics
No merged PRs in 30d

Description

PR https://github.com/pytest-dev/pytest-timeout/pull/200 introduced a breaking change: there is no way now to configure timeout in a way compatible with both 2.4.0 and future release (2.5.0 was released and then yanked).

2.5.0 strictly requires float:

INTERNALERROR> TypeError: /home/yurii/code/1.FastAPI/fastapi/pyproject.toml: config option 'timeout' expects a float, got str: '20.0'

while 2.4.0 strictly requires string:

INTERNALERROR> TypeError: /Users/runner/work/fastapi/fastapi/pyproject.toml: config option 'timeout' expects a string, got float: 20.0

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading PR #200 and the configuration parsing entry point it changed, then reproduce the reported timeout type errors with pytest-timeout 2.4.0 and the newer release. Trace how the timeout value is validated and determine a compatibility-preserving behavior; done means the same configuration works across the affected versions with regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.