pytest-dev / pytest-dev/pytest-qt
Use Stash instead of monkeypatching pytest.Item
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 455
- Forks
- 72
- Avg merge
- 12h 26m
- Merged PRs (30d)
- 1
Description
Maybe
item: pytest.Item,
and add a type ignore about us monkeypatching stuff on it? Long-term, we should be using Stash instead anyways.
Same also for the other utility methods taking item below.
Originally posted by @The-Compiler in https://github.com/pytest-dev/pytest-qt/pull/605#discussion_r2153787063
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the utility methods that accept a pytest.Item and review the linked pytest.Stash reference. Update the affected item-associated state to use Stash, including the other utility methods mentioned, and confirm that type checking and the existing test suite still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100