pytest-dev / pytest-dev/pytest-html
Add typing + mypy
Open
@gnikonorov is already working on this.
Since Dec 21, 2020.
code quality
Infrastructure
- Dominant language
- Python
- Stars
- 779
- Forks
- 260
- PR merge metrics
- No merged PRs in 30d
Description
This project's python code should be typed, and type checking should be part of the CI pipeline. I propose using mypy, we can look at pytest for an example of how to integrate it.
I'm going to try and add in typing. I'll perform changes on a per module level so the reviews are smaller and close this issue when the typing effort is complete. I'll update this issue as I progress
We'd need to do the following subtasks:
Add mypy to our project:done in https://github.com/pytest-dev/pytest-html/pull/435Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/__init__.py:done in https://github.com/pytest-dev/pytest-html/pull/435Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/extras.py:done in https://github.com/pytest-dev/pytest-html/pull/435- Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/hooks.py
- Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/html_report.py
Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/outcome.py:done in https://github.com/pytest-dev/pytest-html/pull/435- Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/plugin.py
- Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/result.py
Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/util.py: done in https://github.com/pytest-dev/pytest-html/pull/435- Type https://github.com/pytest-dev/pytest-html/blob/master/testing/test_pytest_html.py
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.