pytest-dev / pytest-dev/pytest-django
django_db_setup runs inside transactional_db transaction
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 367
- PR merge metrics
- No merged PRs in 30d
Description
If the first db test that gets run happens to have transactional_db (or django_db(transaction=True)) then all subsequent db tests will fail.
This appears to be because the db setup (migrations etc.) are all rolled-back and will not run again because django_db_setup is session-scoped.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure when the first database test uses transactional_db or django_db(transaction=True), then inspect the django_db_setup session fixture and transaction handling. Add a regression test covering that ordering and verify that subsequent database tests still run after setup migrations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- databases, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100