pytest-dev / pytest-dev/pytest-django
Ignore --fail-on-template-vars with default filter?
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 367
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/django/django/pull/8200 was not accepted, but I think it's good to not fail with {{ foo | default:"bar" }} with foo being undefined.
@codingjoe
What do you think?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the rejected PR #8200 and the existing handling of --fail-on-template-vars in pytest-django. Trace the tests around undefined template variables, then clarify whether an undefined variable used with the default filter should be exempt and add coverage for that agreed behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- django, python
- Domain
- backend, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100