pytest-dev / pytest-dev/pytest-django

Databse is not created if there was any contact with DB before test_database_exists_from_previous_run

Open
#176 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.5k
Forks
367
PR merge metrics
No merged PRs in 30d

Description

test_database_exists_from_previous_run silently assumes that the provided connection is closed.
As connection.cursor is not checking for DB name changes, I think pytest-django should either call connection.close() if test name != current name, or fail if connection is already open (because obviously whoever opened it didn't request the db fixture :-))

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate test_database_exists_from_previous_run and inspect how the provided connection is prepared and reused before the test. Reproduce the case where the connection has already interacted with a different database, then determine the expected connection state from the surrounding database fixture tests. Done means the regression is covered and the test passes with the intended connection behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
databases, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.