pytest-dev / pytest-dev/pluggy
tracing: store called hook_impls
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 160
- Avg merge
- 21h 4m
- Merged PRs (30d)
- 6
Description
With tracing I think it would be good to know where the result is coming from (firstresult=True), and/or which hook_impls have been called in general.
But this could also be useful to know in general, so storing it (optionally?) on the _Result seems like a good idea to me.
It should probably not be full references (except for when tracing is enabled, but that's not easy to know when creating the _Result it seems), but only the plugin_name by default.
Related code: https://github.com/pytest-dev/pluggy/blob/a5130ac87a71865192db3959d2e1e1ac41daaca7/src/pluggy/callers.py#L195-L198
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/pluggy/callers.py around lines 195-198 and trace how _Result is created and consumed. Then inspect the tracing path and existing hook_impl handling to clarify whether storage is optional and what information it should retain. Done requires an agreed scope and observable behavior for identifying called implementations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100