pytest-dev / pytest-dev/execnet
More judicious use of file descriptors
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 102
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Description
Currently execnet uses pipes without the CLOEXEC flag. There should be something like this around the parts that make the pipes:
old = fcntl.fcntl(fd, fcntl.F_GETFD)
fcntl.fcntl(fd, fcntl.F_SETFD, old | getattr(fcntl, 'FD_CLOEXEC', 1))
Sorry for incredibly-lousy-without-testcase bug report, I'm just at the end of my wits after figuring out my app is littered with subprocess.Popen without close_fds=True 😤
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Locate the execnet code that creates pipes, then inspect related subprocess or descriptor-handling tests if present. Done means the relevant pipes use the CLOEXEC flag and regression coverage verifies the intended descriptor behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- distributed-systems, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100