pyronear / pyronear/pyro-engine
Move camera credentials from .env to credentials.json
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 19
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Pitch
Thanks to #312, camera management logic has been generalized.
However, the credentials for Reolink cameras are still not defined in a standardized way.
What is done currently
Reolink camera credentials are still stored in .env file
https://github.com/pyronear/pyro-engine/blob/a0825ac2210da37c1b8858f796c883ba01933c7a/README.md?plain=1#L71
https://github.com/pyronear/pyro-engine/blob/a0825ac2210da37c1b8858f796c883ba01933c7a/README.md?plain=1#L72
What should be done
- Updates the code logic to have these camera credentials defined in
credentials.json
(there will be some udpates in the Engine logic) - Updates readme consequently
Happy to discuss it :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the credential examples at the referenced README lines and trace the Engine logic that currently reads Reolink credentials from .env. Update the configuration path to credentials.json, then revise the README so its setup instructions match the new format; verify that camera management still receives the credentials correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100