pyro-ppl / pyro-ppl/pyro

Enable warnings in tests/test_examples.py

Open
#2,201 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted warnings & errors
Dominant language
Python
Stars
9.1k
Forks
1k
Avg merge
1d 13h
Merged PRs (30d)
5

Description

I just noticed that our usual pytest warnings filters (-Werror with a few exceptions) do not apply to the eamples/*.py when run by subprocess.check_call(), leading to some warnings raised by examples.

I tried sketching a possible solution in the example-warnings branch, but it appears difficult to specify exact warnings, and there are some possibly unrelated issues with torch_shm_manager and with the jit raising SystemError: ... returned a result with an error reset.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/test_examples.py and trace how examples/*.py are run through subprocess.check_call(), then compare that path with the usual pytest warning filters. Reproduce the warnings and distinguish them from the reported torch_shm_manager and JIT SystemError issues; done means the relevant example warnings are handled without masking unrelated failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.