Check transformation domain in `TransformedDistribution` constructor?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.8k
- Forks
- 316
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 27
Description
Feature Summary
Distributions know their support. Transformations know their domain and codomain. As far as I can tell, it should therefore be possible to confirm that a transformation used in constructing a TransformedDistribution from a base distribution has a domain equal to the support of the base distribution, and error if not.
Why is this needed?
The lack of an error here can lead to unexpected and somewhat opaque behavior. See e.g. #1756
Questions
- Is there reason to allow the creation of
TransformedDistributionswith a transformation whose domain is not equal to the base distribution's support? - Are there barriers to implementation that I'm not seeing?
Happy to take this on if it would be valuable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the TransformedDistribution constructor and the support and domain definitions for its base distribution and transformation. Reproduce the behavior referenced in #1756, then establish whether mismatches should be rejected and add coverage for the agreed behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100