pypa / pypa/setuptools

Upgrading 19.4 -> 19.6 breaks pyramid_mako tests

Open
#490 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug major
Dominant language
Python
Stars
2.9k
Forks
1.4k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

Originally reported by: iElectric (Bitbucket: iElectric, GitHub: Unknown)


======================================================================
ERROR: test_directories_list (pyramid_mako.tests.Test_parse_options_from_settings)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-python2.7-pyramid_mako-0.3.1.drv-0/pyramid_mako-0.3.1/pyramid_mako/tests.py", line 141, in test_directories_list
    result = self._callFUT(settings)
  File "/tmp/nix-build-python2.7-pyramid_mako-0.3.1.drv-0/pyramid_mako-0.3.1/pyramid_mako/tests.py", line 118, in _callFUT
    self.config.maybe_dotted)
  File "/tmp/nix-build-python2.7-pyramid_mako-0.3.1.drv-0/pyramid_mako-0.3.1/pyramid_mako/__init__.py", line 175, in parse_options_from_settings
    directories = [abspath_from_asset_spec(d) for d in directories]
  File "/nix/store/00j1pcy46fq4pg1mdb5f7vwr4djrln34-python2.7-pyramid-1.5.8/lib/python2.7/site-packages/pyramid/asset.py", line 43, in abspath_from_asset_spec
    return pkg_resources.resource_filename(pname, filename)
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 1153, in resource_filename
    self, resource_name
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 1854, in get_resource_filename
    "resource_filename() only supported for .egg, not .zip"
NotImplementedError: resource_filename() only supported for .egg, not .zip

======================================================================
ERROR: test_multiple_registration_different_name (pyramid_mako.tests.Test_parse_options_from_settings)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-python2.7-pyramid_mako-0.3.1.drv-0/pyramid_mako-0.3.1/pyramid_mako/tests.py", line 239, in test_multiple_registration_different_name
    result = self._callFUT(settings)
  File "/tmp/nix-build-python2.7-pyramid_mako-0.3.1.drv-0/pyramid_mako-0.3.1/pyramid_mako/tests.py", line 118, in _callFUT
    self.config.maybe_dotted)
  File "/tmp/nix-build-python2.7-pyramid_mako-0.3.1.drv-0/pyramid_mako-0.3.1/pyramid_mako/__init__.py", line 175, in parse_options_from_settings
    directories = [abspath_from_asset_spec(d) for d in directories]
  File "/nix/store/00j1pcy46fq4pg1mdb5f7vwr4djrln34-python2.7-pyramid-1.5.8/lib/python2.7/site-packages/pyramid/asset.py", line 43, in abspath_from_asset_spec
    return pkg_resources.resource_filename(pname, filename)
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 1153, in resource_filename
    self, resource_name
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 1854, in get_resource_filename
    "resource_filename() only supported for .egg, not .zip"
NotImplementedError: resource_filename() only supported for .egg, not .zip

----------------------------------------------------------------------
Ran 63 tests in 0.155s

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing test_directories_list and test_multiple_registration_different_name from pyramid_mako/tests.py, then trace the failure through parse_options_from_settings and pkg_resources.resource_filename as shown. Done means these tests pass when upgrading from 19.4 to 19.6, including the reported zip-distribution case.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.