pypa / pypa/setuptools

Requirement.parse implementation doesn't match documented grammar

Open
#461 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug minor
Dominant language
Python
Stars
2.9k
Forks
1.4k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

Originally reported by: Anonymous


According to https://pythonhosted.org/setuptools/pkg_resources.html#requirements-parsing the extras should come after the versionspec e.g. 'requests==0.8.1[security]'. However, this fails with RequirementParseError (Expected ',' or end-of-list in requests==0.8.1[security]), whereas 'requests[security]==0.8.1' works.


Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Requirement.parse entry point and compare its handling of the documented grammar with the two examples in the issue: requests==0.8.1[security] and requests[security]==0.8.1. Reproduce both parsing results first; the issue is complete when the documented extras-after-version form is accepted consistently with the existing form.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.