pypa / pypa/setuptools

PEP 440 compliant version in depenency_link egg fragment

Open
#414 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug major
Dominant language
Python
Stars
2.9k
Forks
1.4k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

Originally reported by: insideapp (Bitbucket: insideapp, GitHub: insideapp)


PEP 440 compliant version is not supported in a dependency link egg fragment. The url parser is only expecting [-A-Za-z0-9_.]+
Such behavior disallow useful PEP 440 features like epoch and local versions.

Is there a point behind such strict regexp? I would expect this fragment to match any string, urlencoded. This version string would in any case be parsed by a Distribution instance and it will do the validation.


Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in setuptools/package_index.py at the URL parser and its version-fragment regular expression. Check how the fragment is passed to Distribution validation, then add coverage for URL-encoded PEP 440 epoch and local versions and confirm those fragments are accepted.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.